[clang] d4fcc69 - Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot

[Aaron Ballman via cfe-commits]

On Wed, Mar 8, 2023 at 11:57 PM via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
>
> Author: jinge90
> Date: 2023-03-09T13:14:36+08:00
> New Revision: d4fcc692ee15b2c6d249daabe31208d6a5afa025
>
> URL: https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025
> DIFF: https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025.diff
>
> LOG: Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot

Hello! I reverted this change along with
24b823554acd25009731b2519880aa18c7263550 because this follow-up
removed all test coverage from the original change. Typically, we
don't disable tests in response to failing bots; it's too easy for the
test to accidentally never get enabled again, and then we have both a
bug and a lack of test coverage. Instead, either the breakage is fixed
in a quick follow-up or the original patch should be reverted. Sorry
for any hassle from the reverts!

~Aaron

>
> Signed-off-by: jinge90 <ge.jin at intel.com>
>
> Added:
>
>
> Modified:
>     clang/test/CodeGen/builtins.c
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/clang/test/CodeGen/builtins.c b/clang/test/CodeGen/builtins.c
> index d523d3100c04c..1281c5e13ae3e 100644
> --- a/clang/test/CodeGen/builtins.c
> +++ b/clang/test/CodeGen/builtins.c
> @@ -278,8 +278,6 @@ void test_float_builtins(__fp16 *H, float F, double D, long double LD) {
>
>    res = __builtin_flt_rounds();
>    // CHECK: call i32 @llvm.get.rounding(
> -  __builtin_set_flt_rounds(1);
> -  // CHECK: call void @llvm.set.rounding(i32 1)
>  }
>
>  // CHECK-LABEL: define{{.*}} void @test_float_builtin_ops
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits