[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

Thu Mar 9 02:53:49 PST 2023

ManuelJBrito added inline comments.

================
Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1
 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f  -target-feature +avx512fp16 -S -o - | FileCheck %s

----------------
aqjune wrote:
> aqjune wrote:
> > This line contains `%s` twice, which seems to cause the crash.
> > 
> > Would removing one of `%s` resolve the crash issue? On my machine removing one of those worked well; with two `%s`; it crashed.
> Actually, with FileCheck's argument counted there are three `%s`, but it isn't important; I meant two `%s` in clang_cc1's arguments.
Oops .. I should have noticed that...
I will try to commit again with this fix . Thanks for looking at this aqjune!!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144903/new/

https://reviews.llvm.org/D144903