[PATCH] D145639: [Coroutines] Fix premature conversion of return object

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

This is basically a reverting of https://reviews.llvm.org/D117087. So it should be good according to our previous talk.



================
Comment at: clang/include/clang/AST/StmtCXX.h:410-414
   Expr *getReturnValue() const {
     assert(getReturnStmt());
     auto *RS = cast<clang::ReturnStmt>(getReturnStmt());
     return RS->getRetValue();
   }
----------------
Maybe we can delete this.


================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:1752
 
-  StmtResult ReturnStmt = S.BuildReturnStmt(Loc, ReturnValue);
+  // StmtResult ReturnStmt = S.BuildReturnStmt(Loc, ReturnValue);
+  auto *GroDecl = VarDecl::Create(
----------------
Let's remove this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145639/new/

https://reviews.llvm.org/D145639