[PATCH] D145605: Revert two patches to fix PR58452 regression

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 8 12:57:36 PST 2023


erichkeane created this revision.
erichkeane added reviewers: tstellar, aaron.ballman.
Herald added a project: All.
erichkeane requested review of this revision.

PR58452 is a regression in the 16.0 release branch caused by both:
b8a1b698afb2fc84819c7596090aabf4d826b436 <https://reviews.llvm.org/rGb8a1b698afb2fc84819c7596090aabf4d826b436> and
3a0309c53674be56b5cfce038d78a0c2c6e2a98c <https://reviews.llvm.org/rG3a0309c53674be56b5cfce038d78a0c2c6e2a98c>

This patch reverts both of those to make the 'valid' code stop diagnosing
at the expense of crashes on invalid + unclear diagnostics.


https://reviews.llvm.org/D145605

Files:
  clang/include/clang/Sema/Sema.h
  clang/include/clang/Sema/SemaInternal.h
  clang/lib/Sema/SemaTemplateDeduction.cpp
  clang/lib/Sema/SemaTemplateVariadic.cpp
  clang/lib/Sema/TreeTransform.h
  clang/test/CXX/temp/temp.decls/temp.variadic/p5.cpp
  clang/test/SemaTemplate/cxx1z-fold-expressions.cpp
  clang/test/SemaTemplate/pack-deduction.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145605.503476.patch
Type: text/x-patch
Size: 21603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230308/ddc1e3f4/attachment-0001.bin>


More information about the cfe-commits mailing list