[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

Wed Mar 8 09:31:32 PST 2023

w2yehia added inline comments.

================
Comment at: clang/test/Driver/ppc-roptr.c:10
+// ROPTR-NOT: "-mroptr"
+// ROPTR-NOT: "-bforceimprw"
+
----------------
hubert.reinterpretcast wrote:
> Do we pass the option through to the LTO codegen when `-fprofile-generate` is used?
> We may need a driver diagnostic for `-mroptr` without data sections when linking LTO objects (because the front-end won't be involved).
> 
> @w2yehia, does LLVM trunk have a gap in LTO driver enablement for AIX?
> does LLVM trunk have a gap in LTO driver enablement for AIX?

I think trunk is up to date in terms of LTO (driver and libLTO); this was done in LLVM 16.0.

> Do we pass the option through to the LTO codegen when -fprofile-generate is used?

what's special with  -fprofile-generate in relation to the ROPTR option?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144190/new/

https://reviews.llvm.org/D144190