[PATCH] D145567: [Driver] Rename multilib flags to tags
Michael Platings via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 8 03:10:35 PST 2023
michaelplatings created this revision.
michaelplatings added a reviewer: phosek.
Herald added a subscriber: abrachet.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
The name "flag" implies a type of command line option which is no longer
how these variables are used in multilib. Although tags often look
similar to command line options this is not a requirement - tags may be
arbitrary strings.
MultilibBuilder still uses the name "flag" since it is designed to be
used only with valid command line options, even though these are
subsequently used as multilib tags. Similarly addMultilibFlag() keeps
its existing name because of how it is used, even though it now takes a
tag_set argument.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D145567
Files:
clang/docs/Multilib.rst
clang/include/clang/Driver/Multilib.h
clang/include/clang/Driver/Options.td
clang/include/clang/Driver/ToolChain.h
clang/lib/Driver/Driver.cpp
clang/lib/Driver/Multilib.cpp
clang/lib/Driver/MultilibBuilder.cpp
clang/lib/Driver/ToolChain.cpp
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib/Driver/ToolChains/CommonArgs.cpp
clang/lib/Driver/ToolChains/CommonArgs.h
clang/lib/Driver/ToolChains/Fuchsia.cpp
clang/lib/Driver/ToolChains/Gnu.cpp
clang/test/Driver/baremetal-multilib.yaml
clang/test/Driver/print-multi-selection-flags.c
clang/test/Driver/print-multi-selection-tags.c
clang/unittests/Driver/MultilibBuilderTest.cpp
clang/unittests/Driver/MultilibTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145567.503293.patch
Type: text/x-patch
Size: 58999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230308/a0a75255/attachment-0001.bin>
More information about the cfe-commits
mailing list