[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 7 15:13:05 PST 2023


phosek added a comment.

In D145449#4175864 <https://reviews.llvm.org/D145449#4175864>, @phosek wrote:

>> LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to
>> stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on
>> two-stage builds.
>
> That shouldn't be the case, do you know where it's being passed through?

Looks like it's being passed through here https://github.com/llvm/llvm-project/blob/c0e9c55db3b6a2a1287ba96ef3d378b97b72714a/clang/CMakeLists.txt#L669 which was introduced by D40258 <https://reviews.llvm.org/D40258>. I'll see if we can remove that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145449/new/

https://reviews.llvm.org/D145449



More information about the cfe-commits mailing list