[PATCH] D145519: [SanitizerBinaryMetadata] Do not add to GPU code

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 7 11:33:41 PST 2023


tra added a comment.

LGTM for NVPTX.



================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp:134
     assert(TargetTriple.isOSBinFormatELF() && "ELF only");
+    assert((!TargetTriple.isNVPTX() && !TargetTriple.isAMDGPU()) &&
+           "Device targets are not supported");
----------------
Nit: `assert(!(TargetTriple.isNVPTX() || TargetTriple.isAMDGPU()))` would be a bit easier to read. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145519/new/

https://reviews.llvm.org/D145519



More information about the cfe-commits mailing list