[PATCH] D145509: [HIP] Fix temporary files
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 7 08:10:32 PST 2023
yaxunl created this revision.
yaxunl added reviewers: tra, MaskRay.
Herald added a reviewer: JDevlieghere.
Herald added a project: All.
yaxunl requested review of this revision.
Currently HIP toolchain uses Driver::GetTemporaryDirectory to
create a temporary directory for some temporary files during
compilation. The temporary directories are not automatically
deleted after compilation. This slows down compilation
on Windows.
Switch to use GetTemporaryPath which only creates temporay
files which will be deleted automatically.
This change is OK for MacOS as lipo does not requires specific
file names (https://ss64.com/osx/lipo.html)
https://reviews.llvm.org/D145509
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/darwin-dsymutil.c
clang/test/Driver/hip-link-bc-to-bc.hip
clang/test/Driver/hip-temps-linux.hip
clang/test/Driver/hip-temps-windows.hip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145509.503048.patch
Type: text/x-patch
Size: 6464 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230307/61eeaf2b/attachment.bin>
More information about the cfe-commits
mailing list