[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Other than the two auto's missing a *, I think this is alright.  I want to think about it/give others a chance to review, so please ping this in a few days if it hasn't been accepted by then.



================
Comment at: clang/lib/Sema/TreeTransform.h:2808
+        isa<FieldDecl, IndirectFieldDecl, MSPropertyDecl>(Member)) {
+      if (auto ThisClass = cast<CXXThisExpr>(Base)
+                               ->getType()
----------------



================
Comment at: clang/lib/Sema/TreeTransform.h:2812
+                               ->getAsCXXRecordDecl()) {
+        auto Class = cast<CXXRecordDecl>(Member->getDeclContext());
+        // In unevaluated contexts, an expression supposed to be a member access
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145491/new/

https://reviews.llvm.org/D145491