[PATCH] D145228: [clangd] Add clangd headers to install targets

[Ivan Murashko via Phabricator via cfe-commits]

ivanmurashko added a comment.

In D145228#4174543 <https://reviews.llvm.org/D145228#4174543>, @kadircet wrote:

> 

I understand concerns about maintenance cost for the change. But I dare to ask why you think it is so high? Perhaps there are different expectations from the feature. I’m not asking to support any API stability or anything like this. IMHO, the maintenance cost for the feature should be on people who would like to use it. Clangd can only export headers and libraries as they are with one addition to allow main function overriding. Users of the feature should be prepared that it might change significantly at any point even within release. There is smaller but similar problem with other many other LLVM APIs, that are significantly changed especially between releases. I hope this expectation should make the maintenance cost for the change smaller and we are happy to support them if it is needed.

There are some additional context about the change. We have a separate build system (not CMake) for in-house apps. The LVVM is considered as a third-party with corresponding libs and headers. The approach allows us to create in-house clang tools such as lint and refactoring tools compiling from the same sources against multiple clang versions and variants. The approach is supported by LLVM modular structure that gives an ability to combine different pieces to create powerful customized in-house apps. Use forks of LLVM is one of the obvious way to use the feature, but it has high maintenance cost and it makes harder to contribute back bug fixes and features. Because we have to pay this cost anyway we can support this feature in upstream for everybody and make LLVM even more re-usable. If we need to support it in another build system, we can do it as well (up to the degree we can in LLVM).

What do you think about it? Have I missed something important?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145228/new/

https://reviews.llvm.org/D145228