[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

[Pavel Kosov via Phabricator via cfe-commits]

kpdev42 marked an inline comment as done.
kpdev42 added inline comments.


================
Comment at: clang/test/Driver/ohos.c:240
+
+// CHECK-OHOS-PTHREAD-NOT: -lpthread
+
----------------
DavidSpickett wrote:
> This one is checking that we do not link to a pthread library, because when using musl, it already provides one?
> 
> Just checking you're not accepting the option but doing the opposite here. Worth adding a comment to explain the reasoning.
Yes, musl implements pthread api, so we do not need to link with libpthread


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145227/new/

https://reviews.llvm.org/D145227