[PATCH] D145438: PLEASE DO NOT COMMENT ON THIS PATCH

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 6 15:17:20 PST 2023


cjdb created this revision.
Herald added a project: All.
cjdb requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This is one of two alternative designs that Clang can adopt when writing
SARIF to file. In this design, the Clang driver invokes a separate tool
that "links" the independent diagnostic files into a single one called
`<target>_sarif`.

Please discuss the //design// of this patch over at
https://discourse.llvm.org/t/adding-options-for-clang-to-write-diagnostics-to-file/67762/,
alongside <OTHER CL>, so that we can incorporate one of them into D145284 <https://reviews.llvm.org/D145284>.
I ask that commentary regarding the implementation be held off until
either this patch or <OTHER CL> is integrated into D145284 <https://reviews.llvm.org/D145284>.

Depends on D145284 <https://reviews.llvm.org/D145284>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145438

Files:
  clang/lib/Tooling/CMakeLists.txt
  clang/lib/Tooling/SarifLinker.cpp
  clang/test/Frontend/sarif-diagnostics.cpp
  clang/tools/CMakeLists.txt
  clang/tools/driver/CMakeLists.txt
  clang/tools/driver/driver.cpp
  clang/tools/sarif-ld/CMakeLists.txt
  clang/tools/sarif-ld/SarifLinker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145438.502825.patch
Type: text/x-patch
Size: 29518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230306/12a4a20c/attachment-0001.bin>


More information about the cfe-commits mailing list