[PATCH] D145391: [HIP] Supports env var HIP_PATH

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 6 13:24:42 PST 2023


MaskRay added inline comments.


================
Comment at: clang/test/Driver/rocm-detect.hip:42
+
+// RUN: rm -rf %T/myhip
+// RUN: rm -rf %T/myhip_nouse
----------------
`%T` is not recommended.

https://llvm.org/docs/CommandGuide/lit.html
"parent directory of %t (not unique, deprecated, do not use)"

Just use `RUN: rm -rf %t && mkdir %t`



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145391/new/

https://reviews.llvm.org/D145391



More information about the cfe-commits mailing list