[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman marked 2 inline comments as done.
aaron.ballman added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:186
+  `#61177 <https://github.com/llvm/llvm-project/issues/61177>`_ in anticipation
+  of `CWG2699 <https://wg21.link/CWG2699>_` being accepted by WG21.
 
----------------
erichkeane wrote:
> This link seems broken?  I get 404 from it.
Correct: `(which is not yet publicly published)` from the summary. That link will become valid whenever CWG issues the next update of the public issues list.


================
Comment at: clang/lib/Sema/SemaStmt.cpp:4354
 
+    QT = QT.getUnqualifiedType();
     if (IsPointer || QT->isReferenceType())
----------------
erichkeane wrote:
> Do we do this because we don't want the pointee unqualified later?  Else these seem identical to me.
We want to strip the top-level qualifiers, and the previous code was stripping qualifiers off the pointee, not the pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145408/new/

https://reviews.llvm.org/D145408