[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

Mon Mar 6 05:32:06 PST 2023

ymandel added a comment.

In D144546#4167161 <https://reviews.llvm.org/D144546#4167161>, @steakhal wrote:

> By looking at the title, I get the impression that this fixes an assertion violation.
> I also observed that this commit is part of `main` but not part of `release/16.x`, hence the `clang-16` would be released without this fix.
>
> I want to raise awareness of backporting crash fixes to llvm releases. IMO that's a good practice.
> So my question is, should we backport this patch to the release branch?
>
> If so, could you please check if there are more commits like this for the dataflow library @ymandel?
>
> I used `git log release/16.x..main --oneline clang/lib/{Analysis,AST,ASTMatchers,StaticAnalyzer} clang/include/clang/{Analysis,AST,ASTMatchers,StaticAnalyzer}  | grep -i 'crash\|fix\|assert'` to check for relevant commits.

Yes, this could be backported. I'm happy to look out for this in the future, but I don't seem to have `release/16.x` in my git repo -- please let me know how to pull that in. I'm only responsible for `Analysis/FlowSensitive`, but even just there not all fixes have those search terms in there commit message.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144546/new/

https://reviews.llvm.org/D144546