[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

Igor Kushnir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 6 03:08:22 PST 2023


vedgy added inline comments.


================
Comment at: clang/include/clang-c/Index.h:3560
+ * If a cursor that is not a bit field declaration is passed in, or if the bit
+ * field's width expression cannot be evaluated, -1 is returned.
  */
----------------
Append the following line to the commit message to properly reference and (hopefully) close the bug automatically:
```
Fixes: https://github.com/llvm/llvm-project/issues/56644
```


================
Comment at: clang/tools/libclang/CXType.cpp:18
 #include "CXType.h"
+#include "clang-c/Index.h"
 #include "clang/AST/Decl.h"
----------------
Since the code worked fine before, I don't think this include should be added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130303/new/

https://reviews.llvm.org/D130303



More information about the cfe-commits mailing list