[PATCH] D145228: [clangd] Add clangd headers to install targets

Mon Mar 6 01:56:14 PST 2023

DmitryPolukhin added a comment.

In D145228#4170792 <https://reviews.llvm.org/D145228#4170792>, @sammccall wrote:

>> The install target for clang distributes the clangd static libs
>
> I don't think this was ever intended, looks like an accidental side-effect of using LLVM's many cmake macros.
> Can we fix this instead?

Why not allow people building custom clangd outside of LLVM repo? There was exactly the same issue with clang-tidy (see D73236 <https://reviews.llvm.org/D73236>) and it was fixed with adding header to the distribution. In comparison with headers, libraries takes much more space so it is just very tiny increase in size and significant convenience for people who need this feature.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145228/new/

https://reviews.llvm.org/D145228