[PATCH] D144454: Add builtin for llvm set rounding
xiongji90 via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 6 00:28:17 PST 2023
xiongji90 added a comment.
Hi, @rjmccall and @sepavloff
I updated built name to "__builtin_set_flt_rounds" as suggested and restrict the built to be used on x86, arm, aarch64 target. I did my local test on x86 and x86_64 and found arm and aarch64 code gen have already supported "llvm.set.rounding" :https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/ARM/ARMISelLowering.cpp#L6398 and https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp#L4528
So enabling the builtin on these targets should be OK. To document, is it ok to create another patch to add doc for both "__builtin_flt_rounds" and "__builtin_set_flt_rounds"?
Thanks very much.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits