[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 5 18:40:29 PST 2023


yaxunl added a comment.

In D145343#4170250 <https://reviews.llvm.org/D145343#4170250>, @arsenm wrote:

> I think exposing whether or not the flag was used is weird/broken, as is including _OPTION in the name. Should just define to whether it's enabled or not

I agree. @b-sumner What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145343/new/

https://reviews.llvm.org/D145343



More information about the cfe-commits mailing list