[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

In D144216#4169764 <https://reviews.llvm.org/D144216#4169764>, @mikecrowe wrote:

>> I will double check that this is true once my current build is complete.
>
> Yes, it's true. I stuck a `#error` in `clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h` and I saw the expected error from a file including `<string>`.

Awesome, thanks for checking, I wasn't aware we already had `string.h`. Then if we do have headers named the same as the standard headers, would it make sense to name this header `cstring` instead of `string`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144216/new/

https://reviews.llvm.org/D144216