[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

[Mike Crowe via Phabricator via cfe-commits]

mikecrowe added a comment.

> The purpose of this header is to not include any standard header, and yet this is done in line 5 so it kinda defeats the purpose.

I believe that this `<string>` header is including `clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h` rather than the system `string.h` header. (That's why I'm including `string.h` to get `size_t` rather than the more obvious `stdlib.h`.) If we're going to have sets of "standard-but-not-standard" headers for these checks then it feels like it ought to be safe to use them.

I will double check that this is true once my current build is complete.

Mike.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144216/new/

https://reviews.llvm.org/D144216