[PATCH] D144709: [clang-format] Improve QualifierAlignment

Sat Mar 4 07:37:39 PST 2023

AlexanderHederstaf added inline comments.

================
Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733
+  // TODO: Something strange is going on with this formating.
+  verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style);
+
----------------
rymiel wrote:
> This... isn't valid syntax? an opening < is missing.
> Perhaps you could adapt https://github.com/llvm/llvm-project/issues/56111 into a test, it seems to be fixed by the patch, but there might still be corner-cases
Right, I must've focused too much on the missing right >. What is the procedure now that the review is accepted. Can I still upload a fix to this and to include that issue in the tests?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144709/new/

https://reviews.llvm.org/D144709