[PATCH] D144709: [clang-format] Improve QualifierAlignment

[Emilia Dreamer via Phabricator via cfe-commits]

rymiel added inline comments.


================
Comment at: clang/unittests/Format/QualifierFixerTest.cpp:523
+  // TODO: Something strange is going on with this formating.
+  verifyFormat("Bar < Foo, Foo const >> ;", "Bar < Foo, const Foo >> ;", Style);
+
----------------
(see below)


================
Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733
+  // TODO: Something strange is going on with this formating.
+  verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style);
+
----------------
This... isn't valid syntax? an opening < is missing.
Perhaps you could adapt https://github.com/llvm/llvm-project/issues/56111 into a test, it seems to be fixed by the patch, but there might still be corner-cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144709/new/

https://reviews.llvm.org/D144709