[PATCH] D129507: [OffloadPackager] Add option to extract files from images

Sat Mar 4 05:40:26 PST 2023

jhuber6 added inline comments.

================
Comment at: clang/test/Driver/offload-packager.c:2-3
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+// REQUIRES: amdgpu-registered-target
+// UNSUPPORTED: system-windows
----------------
bader wrote:
> Are nvptx and amdgpu target required for this test?
> Latest version of the test invokes clang only for x86 target and clang-offload-packager just adds triple as metadata string without using llvm target. Right?
You're right, we could get rid of those. Also this made me realize that the test for the bitcode file isn't actually using bitcode, I should probably fix that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129507/new/

https://reviews.llvm.org/D129507