[PATCH] D144454: Add builtin for llvm set rounding

Thu Mar 2 20:54:35 PST 2023

sepavloff added a comment.

In D144454#4163688 <https://reviews.llvm.org/D144454#4163688>, @rjmccall wrote:

> I see.  If we're going to take the target-independent values specified by `FLT_ROUNDS`, then the original builtin name is more appropriate.  Of course, this has the disadvantage of not allowing target-specific values that might exist beyond those specified in the standard; are we pretty certain that's not a problem in practice?
>
> Working on x86, ARM, and AArch64 is great, but I'm a little worried about adding another builtin that works only on major targets and probably crashes on others.  I suppose we've got some number of those already, though.

Using `fesetround` as compiler builtin requires implementation of constrained intrinsic. It is large work anyway. Adding support for non-standard rounding modes is small relative to it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144454/new/

https://reviews.llvm.org/D144454