[PATCH] D145197: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 15:01:53 PST 2023


jansvoboda11 created this revision.
jansvoboda11 added a reviewer: Bigcheese.
Herald added subscribers: ributzka, mgrang.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

I once again stumbled across `IndexedModuleID` and was confused by the mutable `InputIndex` field.

This patch adds comments around that piece of code and unifies/simplifies related functions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145197

Files:
  clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
  clang/tools/clang-scan-deps/ClangScanDeps.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145197.502005.patch
Type: text/x-patch
Size: 4206 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230302/77baa2cc/attachment.bin>


More information about the cfe-commits mailing list