[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

[Christopher Di Bella via Phabricator via cfe-commits]

cjdb added inline comments.


================
Comment at: clang/test/Frontend/sarif-diagnostics.cpp:31
+// RUN: %clang -fsyntax-only -Wall -Wextra -fdiagnostics-format=sarif-stderr %s > %t.txt 2>&1 || true
+// RUN: FileCheck -dump-input=always %s --input-file=%t.txt --check-prefixes=CHECK,COMMON
+
----------------
cjdb wrote:
> This was split out for future tests where the `COMMON` stuff isn't written to file. Perhaps I should check it in as `STDERR`?
Further thoughts: everything is common, it's a case of where it's output that's not the same. I think with this in mind I should absolutely change `COMMON` to `STDERR`, and possibly `CHECK` to `SARIF`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145178/new/

https://reviews.llvm.org/D145178