[PATCH] D144638: [lit] Detect Inconsistent File Access Times

Sam Elliott via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 05:38:56 PST 2023


lenary added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:190
+                return False
+            if "1995" not in touch_res_out:
+                return False
----------------
michaelplatings wrote:
> This could end up matching the wrong part of the string, for example if the temporary file happened to have 1995 in its name. A regex match for '\b1995\b' would be more reliable.
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144638/new/

https://reviews.llvm.org/D144638



More information about the cfe-commits mailing list