[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 03:17:06 PST 2023


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-member-init-cxx98.cpp:2
 // RUN: %check_clang_tidy -std=c++98 %s cppcoreguidelines-pro-type-member-init %t -- -- -fno-delayed-template-parsing
-
 struct PositiveFieldBeforeConstructor {
----------------
Please revert this unnecessary change.


================
Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h:113
   if (extension == ".cc" || extension == ".cpp" || extension == ".mm") {
-    Args.push_back("-std=c++11");
   }
----------------
Could you break this out into a separate commit with a description like "change ClangTidy unit tests to run in C++20 mode instead of C++11". This is a change, not an extension ("also run in C++20").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144480/new/

https://reviews.llvm.org/D144480



More information about the cfe-commits mailing list