[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

Jacob Young via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 01:40:15 PST 2023


jacobly created this revision.
jacobly added reviewers: efriedma, aaron.ballman.
Herald added a project: All.
jacobly requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

With the Microsoft ABI, some destructors need to offset a parameter to
get the derived this pointer, in which case the type of that parameter
should not be a pointer to the derived type.

Fixes #60465


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145148

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/CodeGen/CGCXXABI.h
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CGExprCXX.cpp
  clang/lib/CodeGen/MicrosoftCXXABI.cpp
  clang/test/CodeGenCXX/constructor-destructor-return-this.cpp
  clang/test/CodeGenCXX/cxx2a-destroying-delete.cpp
  clang/test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp
  clang/test/CodeGenCXX/microsoft-abi-structors.cpp
  clang/test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145148.501807.patch
Type: text/x-patch
Size: 20231 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230302/b2abb7dc/attachment-0001.bin>


More information about the cfe-commits mailing list