[PATCH] D144454: Add builtin for llvm set rounding

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

I see.  If we're going to take the target-independent values specified by `FLT_ROUNDS`, then the original builtin name is more appropriate.  Of course, this has the disadvantage of not allowing target-specific values that might exist beyond those specified in the standard; are we pretty certain that's not a problem in practice?

Working on x86, ARM, and AArch64 is great, but I'm a little worried about adding another builtin that works only on major targets and probably crashes on others.  I suppose we've got some number of those already, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144454/new/

https://reviews.llvm.org/D144454