[PATCH] D144603: Add option to disable compiler launcher on external projects

Wed Mar 1 13:53:52 PST 2023

haowei added a comment.

In D144603#4162223 <https://reviews.llvm.org/D144603#4162223>, @phosek wrote:

> I agree, in that case let's remove `C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER` from the list of default passthrough variables which seems like a reasonable default, and provide `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH` so developers have a way to pass these through to the next stage if they want to.

There is already a `CLANG_BOOTSTRAP_PASSTHROUGH` flag https://github.com/llvm/llvm-project/blob/dc1c8917afd3f2b306797890a56be66087feb832/clang/CMakeLists.txt#L749 that works in the way you describe the `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH` flag.

I think remove the compiler launcher from default pass through flags are fine. What about the using compiler launcher in runtime builds? I don't think we should read `CLANG_BOOTSTRAP_PASSTHROUGH` to determine if we should pass through compiler launcher flags.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144603/new/

https://reviews.llvm.org/D144603