[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 1 08:45:41 PST 2023


asb created this revision.
asb added reviewers: kito-cheng, jrtc27, reames, craig.topper.
Herald added subscribers: luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, arichardson.
Herald added a project: All.
asb requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: clang.

For trivial cases (`_Float16` as a standalone argument), it was previously correctly lowered to `half`. But the logic for catching cases involving structs was gated off, as at the time that logic was written the ABI for half was unclear.

This patch fixes that and adds a release note.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145074

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/CodeGen/TargetInfo.cpp
  clang/test/CodeGen/RISCV/riscv32-abi.c
  clang/test/CodeGen/RISCV/riscv64-abi.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145074.501528.patch
Type: text/x-patch
Size: 41490 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230301/21803900/attachment-0001.bin>


More information about the cfe-commits mailing list