[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

Zequan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 14:22:39 PST 2023


zequanwu added a comment.

Thanks for fixing it.

Just one comment.



================
Comment at: clang/test/CoverageMapping/terminate-statements.cpp:335
+  ( true ? void (0) : abort() );  // CHECK: Gap,File 0, [[@LINE]]:33 -> [[@LINE+1]]:3 = #1
+  ( false ? void (0) : abort() ); // CHECK: Gap,File 0, [[@LINE]]:34 -> [[@LINE+1]]:3 = #2
+  return 0;
----------------
For completeness, can you add following two tests:
```
( true ? abort() : void (0) );
( false ? abort() : void (0) );
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144371/new/

https://reviews.llvm.org/D144371



More information about the cfe-commits mailing list