[PATCH] D144993: [OpenMP]Emit captured decls for target data if no devices were specified.

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 11:32:46 PST 2023


jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LG, thanks a lot for the quick fix.



================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7294
+          // Emit helper decls of the use_device_ptr/use_device_addr clauses.
+          for (const auto *C : S.getClausesOfKind<OMPUseDevicePtrClause>())
+            for (const Expr *E : C->varlists()) {
----------------
nit. I prefer outer braces if and inner blocks have braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144993/new/

https://reviews.llvm.org/D144993



More information about the cfe-commits mailing list