[PATCH] D144709: [clang-format] Improve QualifierAlignment

Emilia Dreamer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 09:09:54 PST 2023


rymiel added a comment.

In D144709#4158555 <https://reviews.llvm.org/D144709#4158555>, @AlexanderHederstaf wrote:

> Discovered incorrect code generation for  `llvm/include/llvm/ADT/StringMap.h`.
>
>   using base = StringMapIterBase<StringMapConstIterator<ValueTy>,
>                                  const StringMapEntry<ValueTy>>;
>
> was converted to, removing two characters. I checked the Token length in InsertQualifierAfter and found that it was not 1. How should I proceed with this particular issue @MyDeveloperDay
>
>   using base = StringMapIterBase<StringMapConstIterator<ValueTy>,
>                                  StringMapEntry<ValueTy> const
>
> I commited the change to SetLength(1) but that looks a bit much like a hack, perhaps anyone more familiar with the codebase can have a look at this issue.

Looks like https://github.com/llvm/llvm-project/issues/56111


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144709/new/

https://reviews.llvm.org/D144709



More information about the cfe-commits mailing list