[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 07:14:18 PST 2023


ChuanqiXu added a comment.

In D144626#4158290 <https://reviews.llvm.org/D144626#4158290>, @erichkeane wrote:

> In D144626#4157240 <https://reviews.llvm.org/D144626#4157240>, @ChuanqiXu wrote:
>
>> This is another revision (https://reviews.llvm.org/D144707) which shouldn't be related with libcxx's modular build. So the failures should be irrelevant with the revision. @erichkeane @royjacobson Do you think it makes sense to land this revision in this case?
>
> Ah, sorry, I meant to come back to this and let you know...  The libcxx modules builds are broken for an unknown reason unrelated to this.  Feel free to land this.

Thanks~


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144626/new/

https://reviews.llvm.org/D144626



More information about the cfe-commits mailing list