[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

Wang Pengcheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 00:34:05 PST 2023


pcwang-thead abandoned this revision.
pcwang-thead added a comment.

In D144853#4157629 <https://reviews.llvm.org/D144853#4157629>, @MaskRay wrote:

> I object to this change which further complicates the build system and makes the difference difficult to observe by users.
> If your `clang` executable is at `bin/clang`, just create `bin/riscv64-unknown-linux-gnu.cfg` with `-mcpu=xxx`.
> You may configure `LLVM_DEFAULT_TARGET_TRIPLE=riscv64-unknown-linux-gnu` so that the driver doesn't need extra `--target=`.

Thanks! I almost forget about config file.
I think this change is unnecessary now and thanks all for your time to review this patch. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144853/new/

https://reviews.llvm.org/D144853



More information about the cfe-commits mailing list