[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/test/CXX/drs/dr25xx.cpp:5-14
+#error one
+// expected-error at -1 {{one}}
+#if 0
+#error skip
+#warning skip // expected-error {{skip}}
+#endif
+#error two
----------------
cor3ntin wrote:
> aaron.ballman wrote:
> > What do these tests have to do with this DR?
> This dr is wild https://wiki.edg.com/pub/Wg21issaquah2023/StrawPolls/p2796r0.html
> CWG merged the static_assert PR in the DR asserting that error should produce a diagnostics - note that there will probably be some follow ups
> https://lists.isocpp.org/core/2023/02/13915.php
> 
> Here I'm testing a warning is emitted even if the build was already failed.
Ah, yeah, CWG2700 is sort of included in here.

I wonder if we should back out the `#error`/`#warning` tests and handle that explicitly as part of CWG2700 as that's going to supersede the changes from CWG2518.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144285/new/

https://reviews.llvm.org/D144285