[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

DonĂ¡t Nagy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 27 08:09:43 PST 2023


donat.nagy added a comment.

@vabridgers Thanks for testing these commits!

As @balazske wrote on D144622 <https://reviews.llvm.org/D144622>, I'd suggest handling the three commits (this one = D140562 <https://reviews.llvm.org/D140562>, D144622 <https://reviews.llvm.org/D144622> and D144273 <https://reviews.llvm.org/D144273>) separately, because they are fixing analogous, but independent problems. (They affect separate branches of the import process and as far as I see they do not influence each other.)

As this commit seems to be ready, I'd suggest merging this now (while we wait for improvements on the other two). @vabridgers What do you think about this plan? Do you see any dependency between the three commits that would make merging just one of them problematic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140562/new/

https://reviews.llvm.org/D140562



More information about the cfe-commits mailing list