[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

[Vince Bridgers via Phabricator via cfe-commits]

vabridgers added a comment.

Patch D144622 <https://reviews.llvm.org/D144622> should be integrated into this one when a reduced reproducer has been prepared as a unittest and/or LIT case.

I verified the patch stack D144273 <https://reviews.llvm.org/D144273>, D140562 <https://reviews.llvm.org/D140562>, and D144622 <https://reviews.llvm.org/D144622> (this one) addresses the problems we've seen as a result of D133468 <https://reviews.llvm.org/D133468>. When the patches are ready, a brief history should be included in the commit header.



================
Comment at: clang/lib/AST/ASTContext.cpp:4627
   } else {
-    Type *newType =
-      new (*this, TypeAlignment) InjectedClassNameType(Decl, TST);
+    Type *newType = new (*this, TypeAlignment) InjectedClassNameType(Decl, TST);
     Decl->TypeForDecl = newType;
----------------
whisperity wrote:
> (Potentially unrelated change, only touching the format?)
@whisperity is correct, please correct this formatting so it's not a change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140562/new/

https://reviews.llvm.org/D140562