[PATCH] D144790: [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

Alexis Murzeau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 25 14:32:08 PST 2023


amurzeau created this revision.
amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
amurzeau requested review of this revision.
Herald added subscribers: cfe-commits, aheejin.
Herald added a project: clang-tools-extra.

The CharPrinter is a typo and should have been named CharPointer as it
configures the hungarian notation prefix for char pointers (char*).

As all configuration options within
readability-identifier-naming.HungarianNotation.CString.* were not read
at all in the previous clang-tidy version (fixed in D144431 <https://reviews.llvm.org/D144431>), this option
rename won't break existing users.

A note in release notes is added to let users know these options were
renamed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144790

Files:
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/readability/identifier-naming.rst
  clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144790.500452.patch
Type: text/x-patch
Size: 4678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230225/ad8668ed/attachment.bin>


More information about the cfe-commits mailing list