[PATCH] D140925: [CMake] Use Clang to infer the target triple

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 24 14:46:53 PST 2023


MaskRay added a comment.

In D140925#4151524 <https://reviews.llvm.org/D140925#4151524>, @smeenai wrote:

> Ping @ldionne, would you be able to take a look at this soon (or are you okay waiving the libc++ blocking requirement for it)? This is really useful for Android armv7, where the triple is traditionally spelled armv7-none-linux-androideabi but normalized to arvm7-none-linux-android, and this patch would resolve that discrepancy.

This patch looks reasonable. The target triple example can be added into "and avoids the issue where the build uses a different triple spelling." @phosek


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140925/new/

https://reviews.llvm.org/D140925



More information about the cfe-commits mailing list