[PATCH] D144709: [clang-format] Improve west to east const

Alexander Hederstaf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 24 01:32:12 PST 2023


AlexanderHederstaf added a reviewer: MyDeveloperDay.
AlexanderHederstaf added a comment.

I tried to refactor QualifierAlignmentFixer to handle more types, notably removing the *,&,&& requirement as e.g. const Foo did not work. To avoid moving qualifiers too far, a test for "already east const" is introduced. However, to get the correct order for the east qualifiers Clang-Format must be used twice. I assume it's related to how fixes/replacements are handled. Would you like to have a look and perhaps suggest any improvements?

As it must be used twice, some tests related to volatile/const order fail, but I noticed most of them would also fails previously if the type is not simple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144709/new/

https://reviews.llvm.org/D144709



More information about the cfe-commits mailing list