[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

Fri Feb 24 00:57:08 PST 2023

kadircet added a comment.

In D142890#4149181 <https://reviews.llvm.org/D142890#4149181>, @vitalybuka wrote:

> One of your patches likely introduced UB https://lab.llvm.org/buildbot/#/builders/85/builds/14558
> Can you please take a look?

Thanks a lot Vitaly and sorry for not noticing this myself :(
This sounds to me like a bad consequence between an empty stringref and memorybuffers. I've put together https://reviews.llvm.org/D144706 to make sure we can prevent this from happening in the library, but getting it reviewed will probably take time.
In the meanwhile I've sent out https://reviews.llvm.org/D144708 to stop the bleeding.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142890/new/

https://reviews.llvm.org/D142890