[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers
Arthur Eubanks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 23 18:14:28 PST 2023
aeubanks added inline comments.
================
Comment at: clang/lib/CodeGen/Address.h:28
-// We try to save some space by using 6 bits over two PointerIntPairs to store
-// the alignment. However, some arches don't support 3 bits in a PointerIntPair
-// so we fallback to storing the alignment separately.
-template <typename T, bool = alignof(llvm::Value *) >= 8> class AddressImpl {};
-
-template <typename T> class AddressImpl<T, false> {
+class AddressImpl {
llvm::PointerIntPair<llvm::Value *, 1, bool> PointerAndKnownNonNull;
----------------
we should remove this class altogether
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144686/new/
https://reviews.llvm.org/D144686
More information about the cfe-commits
mailing list