[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 18:03:10 PST 2023


ChuanqiXu added a comment.

The test should be required here.



================
Comment at: clang/lib/CodeGen/CGExpr.cpp:544
       // so that it's unconditional. Don't do this with sanitizers which need
       // more precise lifetime marks.
       ConditionalEvaluation *OldConditional = nullptr;
----------------
We should add comment to explain why we add a forward path for coroutines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144680/new/

https://reviews.llvm.org/D144680



More information about the cfe-commits mailing list