[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 09:07:32 PST 2023


erichkeane added a comment.

I think the problem is more that we are modifying the expression in the AST.  I don't think now that we have the 'deferred concepts instantiation' that we should be storing/saving the updated requires clause back to the AST, right?  We should be re-evaluating it (with a cache!).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144626/new/

https://reviews.llvm.org/D144626



More information about the cfe-commits mailing list