[PATCH] D144638: [lit] Detect Consistent File Access Times

[James Henderson via Phabricator via cfe-commits]

jhenderson added a comment.

This looks reasonable to me, with the caveat that I don't know a huge amount about how the different OSes access time systems work. One question though: if your antivirus was causing flakiness (as opposed to outright always-fails), won't it just move that flakiness into whether the REQUIRES calculation returns true or not (i.e. it could spuriously do so, causing the tests to be enabled but then potential still be flaky?



================
Comment at: llvm/utils/lit/lit/llvm/config.py:165
+    #
+    # This check hopefully detects both cases, and disables tests that require
+    # consistent atime.
----------------
Is "hopefully" really needed here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144638/new/

https://reviews.llvm.org/D144638